Skip to content

Optionally get rid of intermediary boxes in visualize, and add more labels#5976

Merged
jrbourbeau merged 5 commits intodask:masterfrom
jsignell:visualize
Mar 6, 2020
Merged

Optionally get rid of intermediary boxes in visualize, and add more labels#5976
jrbourbeau merged 5 commits intodask:masterfrom
jsignell:visualize

Conversation

@jsignell
Copy link
Copy Markdown
Member

@jsignell jsignell commented Mar 4, 2020

  • Tests added / passed
  • Passes black dask / flake8 dask

This PR adds the collapse and verbose options to visualize. Collapse gets rid of all non-connected non-task boxes as well as any boxes that are just the output of a task that feeds into other tasks. Verbose adds a label to all the boxes even if the label is a duplicate.

This came up in #5928. Here are some images of what the new graphs from that page would look like:

With lots of intermediary outputs

collapse=False collapse=True
verbose=False image image
verbose=True image image

With unconnected nodes

collapse=False collapse=True
verbose=False image image
verbose=True image image

@jsignell
Copy link
Copy Markdown
Member Author

jsignell commented Mar 4, 2020

@quasiben since we were talking about this at the dask meeting.

Copy link
Copy Markdown
Member

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks really nice.

Do you have an example of collapse removing an unconnected box? Or is it in the examples you posted and I just missed it?

@TomAugspurger
Copy link
Copy Markdown
Member

CI failure is just #5972, which I haven't had any luck with yet.

@jsignell
Copy link
Copy Markdown
Member Author

jsignell commented Mar 5, 2020

I added an unconnected nodes example to the first comment.

@TomAugspurger
Copy link
Copy Markdown
Member

Great, thanks.

I pushed a commit merging master, which should make the CI failure go away.

Copy link
Copy Markdown
Member

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging later today if there aren't any objections.

@jsignell
Copy link
Copy Markdown
Member Author

jsignell commented Mar 6, 2020

Thanks!

@jsignell
Copy link
Copy Markdown
Member Author

jsignell commented Mar 6, 2020

I'll redo #5928 once this is in :)

@jrbourbeau jrbourbeau merged commit da4f60d into dask:master Mar 6, 2020
@jrbourbeau
Copy link
Copy Markdown
Member

Thanks @jsignell!

@jsignell jsignell deleted the visualize branch March 6, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants