Skip to content

Add Tom's log config example#6143

Merged
martindurant merged 3 commits intodask:masterfrom
martindurant:log_details
Apr 28, 2020
Merged

Add Tom's log config example#6143
martindurant merged 3 commits intodask:masterfrom
martindurant:log_details

Conversation

@martindurant
Copy link
Copy Markdown
Member

@martindurant
Copy link
Copy Markdown
Member Author

It seems to me that the "Logs" heading should be promoted one level
https://docs.dask.org/en/latest/debugging.html#logs

@martindurant martindurant requested a review from jakirkham April 27, 2020 17:28
Copy link
Copy Markdown
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks really good, thanks for including it @martindurant! I've left a few minor comments

@martindurant martindurant merged commit 984bb14 into dask:master Apr 28, 2020
@martindurant martindurant deleted the log_details branch April 28, 2020 13:54
@martindurant martindurant mentioned this pull request Apr 28, 2020
@jakirkham
Copy link
Copy Markdown
Member

This is great! Thanks for capturing this Martin! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write logs to disk as well

4 participants