Move key_split() back to utils.py#6529
Merged
mrocklin merged 1 commit intodask:masterfrom Aug 18, 2020
Merged
Conversation
Member
|
This seems good to me. Thanks for the cleanup @madsbk |
sjperkins
added a commit
to ratt-ru/dask-ms
that referenced
this pull request
Aug 27, 2020
kumarprabhu1988
pushed a commit
to kumarprabhu1988/dask
that referenced
this pull request
Oct 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves
key_split()back toutils.py. It was moved previously as part of #1919 to fix "messy circular imports" however I don't think this is needed anymore. As far as I can see the dependencies are:thus importing
utils.pyfrom anywhere excludingcore.pyandutils_test.pyshould be fine.My issue with having
key_split()inoptimization.pyis that I get circular imports whenoptimization.pyimportshighlevelgraph.py:black dask/flake8 dask