Merged
Conversation
This makes it possible to cull ShuffleLayer without materializing
rjzamora
approved these changes
Oct 28, 2020
| """ | ||
| deps = defaultdict(set) | ||
| parts_out = self._keys_to_parts(keys) | ||
| parts_out = parts_out or self._keys_to_parts(keys) |
| self.meta_input = meta_input | ||
| self.parts_out = parts_out or range(npartitions) | ||
|
|
||
| def get_output_keys(self): |
Member
There was a problem hiding this comment.
Not that it should be in this PR, but should we be able to implement something similar for other Layer types (like Blockwise)?
Contributor
Author
There was a problem hiding this comment.
Yes, implementing layer specific get_output_keys() will be essential to avoid materialization.
Contributor
Author
|
@jrbourbeau I think this is ready to be merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
HighLevelGraph.get_all_external_keys(), which makes it possible to cull high level graphs that containsShuffleLayerwithout materializing them.black dask/flake8 daskcc. @rjzamora