Merged
Conversation
mrocklin
reviewed
Nov 9, 2020
Contributor
|
Thank you @jsignell for looking into it! |
jsignell
force-pushed
the
blocksize-in-name
branch
from
3911bbb to
c5137c1
Compare
mrocklin
reviewed
Nov 11, 2020
dask/dataframe/io/tests/test_csv.py
Outdated
| reader, blocks, header, head, kwargs, blocksize="30B" | ||
| ) | ||
| value_names = {key[0] for key in values.dask.keys()} | ||
| assert value_names != df_names |
Member
There was a problem hiding this comment.
This works, and I'm happy to see this merged in. However, if we wanted to use more public API and make things a bit easier for future maintainers we might do the following instead:
def test_different_names():
with filetext(text) as fn:
a = dd.read_csv(fn, blocksize="10kB")
b = dd.read_csv(fn, blocksize="20kB")
assert a.name != b.name
Member
Author
There was a problem hiding this comment.
It's the goldilocks of tests! I'm happy to change it to that.
Member
|
Thanks @jsignell for fixing this and @nils-braun for raising |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
black dask/flake8 daskCloses #6814
I am still thinking about how to add tests. I think this only happens on a distributed cluster.