Skip to content

__dask_distributed_pack__(): client argument#6850

Merged
jrbourbeau merged 1 commit intodask:masterfrom
madsbk:dask_distributed_pack_client_arg
Nov 18, 2020
Merged

__dask_distributed_pack__(): client argument#6850
jrbourbeau merged 1 commit intodask:masterfrom
madsbk:dask_distributed_pack_client_arg

Conversation

@madsbk
Copy link
Copy Markdown
Contributor

@madsbk madsbk commented Nov 17, 2020

This PR adds a client argument to Layer.__dask_distributed_pack__(), which is need when serializing Blockwise (see #6848)

Notice, this PR should be merged together with dask/distributed#4248

  • Tests added / passed
  • Passes black dask / flake8 dask

Copy link
Copy Markdown
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @madsbk! This LGTM, but let's wait until CI is done running over in dask/distributed#4248 so we can merge these PRs together

@jrbourbeau jrbourbeau merged commit bf17b72 into dask:master Nov 18, 2020
@madsbk madsbk deleted the dask_distributed_pack_client_arg branch November 18, 2020 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants