Skip to content

Set npartitions in set_index#6978

Merged
jsignell merged 2 commits intodask:masterfrom
jsignell:npartitions
Dec 18, 2020
Merged

Set npartitions in set_index#6978
jsignell merged 2 commits intodask:masterfrom
jsignell:npartitions

Conversation

@jsignell
Copy link
Copy Markdown
Member

@jsignell jsignell commented Dec 15, 2020

This causes some test failures, so I was hoping to get some advice on whether this is how npartitions is meant to be used on set_index

@rjzamora
Copy link
Copy Markdown
Member

Hmm - The test_set_index_timezone failure may not be a problem. It seems that the test is calling d.set_index("notz", npartitions=1) and d.set_index("tz", npartitions=2), but getting a single partition for both cases anyway. There is no failure with npartition=1 (which is what the test was usually getting anyway).

@jsignell
Copy link
Copy Markdown
Member Author

I did notice that it wasn't getting npartitions set properly. I'll try to fix the tests tomorrow.

@jsignell jsignell marked this pull request as ready for review December 18, 2020 17:28
@jsignell jsignell merged commit 8c46b58 into dask:master Dec 18, 2020
@jsignell jsignell deleted the npartitions branch December 18, 2020 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

npartitions argument in set_index DataFrame method does not work.

2 participants