Comparing string versions won't always work#6979
Merged
martindurant merged 1 commit intodask:masterfrom Dec 17, 2020
Merged
Conversation
Fixed some cupy and sparse tests. cupy were still fine, but sparse actually skips the test since: > "0.11.2" < "0.7.0+1" on strings evaluates to True.
Member
|
Thank you, this looks useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed some cupy and sparse skip test markers. cupy were still fine, but sparse actually skips the test on the recent version of sparse (0.11.2):
on strings evaluates to
True.black dask/flake8 dask