Merged
Conversation
jsignell
commented
Dec 18, 2020
| @derived_from(pd.Series) | ||
| def groupby(self, by=None, **kwargs): | ||
| def groupby( | ||
| self, by=None, group_keys=True, sort=None, observed=None, dropna=None, **kwargs |
Member
Author
There was a problem hiding this comment.
This make the kwargs show up as supported in the docstrings
Member
Author
|
I think I need to set a min pandas version for this feature or for the test at least. |
Member
Author
|
@dask/maintenance I think this is ready to go in. |
Member
|
Also test |
This was referenced Jan 6, 2021
abduhbm
pushed a commit
to abduhbm/dask
that referenced
this pull request
Jan 19, 2021
* Pass dropna and observed in agg * Add test for the issue * Raise error if pandas is less than 1.1.0 * Add observed test and fix xfailed test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
black dask/flake8 dask