Skip to content

Deprecate HighlevelGraph.dicts in favour of .layers#7145

Merged
jrbourbeau merged 1 commit intodask:masterfrom
aktech:deprecate-dicts
Jan 29, 2021
Merged

Deprecate HighlevelGraph.dicts in favour of .layers#7145
jrbourbeau merged 1 commit intodask:masterfrom
aktech:deprecate-dicts

Conversation

@aktech
Copy link
Copy Markdown
Contributor

@aktech aktech commented Jan 29, 2021

  • Tests added / passed
  • Passes black dask / flake8 dask

Replaces all usage of .dicts with .layers and deprecates .dicts.
Fixes #7108

cc @jrbourbeau @crusaderky

Copy link
Copy Markdown
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aktech!

@jrbourbeau jrbourbeau merged commit 34f990a into dask:master Jan 29, 2021
@jrbourbeau
Copy link
Copy Markdown
Member

Also, I noticed this was your first code contribution here. Welcome!

@aktech aktech deleted the deprecate-dicts branch January 29, 2021 23:04
@aktech
Copy link
Copy Markdown
Contributor Author

aktech commented Jan 29, 2021

Also, I noticed this was your first code contribution here. Welcome!

Yes & thanks for the superfast response!

@crusaderky
Copy link
Copy Markdown
Collaborator

looks great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up the HighlevelGraph.dicts property

3 participants