Skip to content

Drop duplicate test in test_describe_empty#7431

Merged
jrbourbeau merged 1 commit intodask:mainfrom
jakirkham:drop_dup_tst
Mar 22, 2021
Merged

Drop duplicate test in test_describe_empty#7431
jrbourbeau merged 1 commit intodask:mainfrom
jakirkham:drop_dup_tst

Conversation

@jakirkham
Copy link
Copy Markdown
Member

It appears this test is run twice. Since it is already covered once, just drop the second one.

  • Closes #xxxx
  • Tests added / passed
  • Passes black dask / flake8 dask

It appears this test is run twice. Since it is already covered once,
just drop the second one.
Comment on lines 473 to 474

with pytest.raises(ValueError):
ddf_len0.describe(percentiles_method="dask").compute()

with pytest.raises(ValueError):
ddf_len0.describe(percentiles_method="dask").compute()
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test appears to be run twice (unless I'm missing something). So have just dropped one of these

Copy link
Copy Markdown
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jakirkham!

@jrbourbeau jrbourbeau merged commit 1315469 into dask:main Mar 22, 2021
@jakirkham jakirkham deleted the drop_dup_tst branch March 22, 2021 16:34
@jakirkham
Copy link
Copy Markdown
Member Author

Thanks James! 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants