Array: Fix NEP18 dispatching in finalize#7508
Merged
Conversation
dask#4669 was meant to do this, but it wasn't working anymore. Turns out `arr.__array_function__ is not type(arr).__array_function__`, even when `arr` is a plain ndarray. So I believe we've actually being going down the `_concatenate2` path for all array types, even plain ndarrays where we could do the more efficient fill-in-the-blocks method of `concatenate3`.
gjoseph92
commented
Apr 2, 2021
|
|
||
| for (idx, arr) in zip(slices_from_chunks(chunks), core.flatten(arrays)): | ||
| for (idx, arr) in zip( | ||
| slices_from_chunks(chunks), core.flatten(arrays, container=(list, tuple)) |
Collaborator
Author
There was a problem hiding this comment.
Adding container=(list, tuple) to flatten here is a driveby. Seemed weird to me that we gave it earlier in the function but not here. Not sure if there's any reason for the inconsistency, so I made it consistent.
Collaborator
Author
|
FYI @jsignell I found this in the process of pulling the ndarray-subclass commits out #7491 (comment) |
jsignell
approved these changes
Apr 21, 2021
Member
jsignell
left a comment
jsignell
left a comment
There was a problem hiding this comment.
This looks good to me. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4669 was meant to do this, but it wasn't working anymore. Turns out
arr.__array_function__ is not type(arr).__array_function__, even whenarris a plain ndarray. So I believe we've actually being going down the_concatenate2path for all array types, even plain ndarrays where we could do the more efficient fill-in-the-blocks method ofconcatenate3.black dask/flake8 dask/isort dask