Add some basic examples to doc strings on dask.bag all, any, count methods#7630
Merged
jrbourbeau merged 3 commits intodask:mainfrom Sep 30, 2021
Merged
Conversation
Contributor
|
I like these, I think it's helpful to have them here. |
Member
|
Looks like there are still some linting issues. If you run |
…s-to-dask-bags
Collaborator
|
Can one of the admins verify this patch? |
Member
|
add to allowlist |
jrbourbeau
approved these changes
Sep 30, 2021
Member
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @ndanielsen! I merged main and ran our pre-commit hooks (hope that's okay). This looks great, will merge once CI finishes up
Also, I noticed this is your first code contribution to this repository. Welcome!
Contributor
Author
|
Thanks @jrbourbeau feels good to contribute here! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found the API documentation was lacking basic examples on these methods, so figured this would be helpful to others.
black dask/flake8 dask/isort dask