Skip to content

Bag: add implementation for reservoir sampling (#7068)#7636

Merged
jsignell merged 2 commits intodask:mainfrom
mesejo:feature-implement-reservoir-sampling
Mar 16, 2022
Merged

Bag: add implementation for reservoir sampling (#7068)#7636
jsignell merged 2 commits intodask:mainfrom
mesejo:feature-implement-reservoir-sampling

Conversation

@mesejo
Copy link
Copy Markdown
Contributor

@mesejo mesejo commented May 9, 2021

  • Closes Implement reservoir sampling for Bag #7068.
    • Implement the L algorithm for reservoir sampling without replacement.
    • Use the k reservoir of size 1 strategy for sampling with replacement (see reference) of k items
  • Tests added / passed. Including those for verifying the correctness of the algorithm implementation
  • Passes black dask / flake8 dask / isort dask

@mesejo mesejo force-pushed the feature-implement-reservoir-sampling branch 7 times, most recently from b2b75f7 to abeea84 Compare May 14, 2021 19:05
* Implements reservoir sampling L algorithm
@mesejo mesejo force-pushed the feature-implement-reservoir-sampling branch from abeea84 to 6a29a05 Compare May 25, 2021 19:56
@jsignell jsignell added the bag label May 26, 2021
@jsignell
Copy link
Copy Markdown
Member

jsignell commented Jun 8, 2021

@dask/maintenance I'm not sure who has the right bag expertise to review this.

@jsignell jsignell added the needs review Needs review from a contributor. label Feb 28, 2022
Copy link
Copy Markdown
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @mesejo! Thanks for taking this work on and sorry it sat in review for so long. I am planning on merging it today.

@jsignell jsignell added almost done Work is almost done! and removed needs review Needs review from a contributor. labels Mar 16, 2022
@jsignell jsignell merged commit 4e5dfe7 into dask:main Mar 16, 2022
@jsignell jsignell removed the almost done Work is almost done! label Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement reservoir sampling for Bag

2 participants