Blockwise: handle constant key inputs#7734
Merged
jrbourbeau merged 3 commits intodask:mainfrom Jun 2, 2021
Merged
Conversation
madsbk
force-pushed
the
blockwise_literals_as_keys
branch
from
5f5220c to
4ffa6c0
Compare
madsbk
changed the title
madsbk
changed the title
madsbk
force-pushed
the
blockwise_literals_as_keys
branch
from
fb1c056 to
ae2a4f3
Compare
jrbourbeau
changed the title
jrbourbeau
reviewed
Jun 1, 2021
4 tasks
madsbk
force-pushed
the
blockwise_literals_as_keys
branch
from
c9f5edc to
4527af8
Compare
madsbk
force-pushed
the
blockwise_literals_as_keys
branch
from
4527af8 to
2078ab2
Compare
madsbk
changed the title
Contributor
Author
|
Rebased on main now that #7739 has been merged. |
jrbourbeau
approved these changes
Jun 2, 2021
Member
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @madsbk! This is in
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blockwise didn't handle input literals/constants given as graph keys correctly. Instead of embedding the keys in the
SubgraphCallable, we now handles them like graph keys.Closes #7724
Closes #7681
Depend on #7739, the deprecated warnings will fail the Python v3.9 test runsblack dask/flake8 dask/isort daskcc. @gjoseph92 @trivialfis, @rjzamora, @jrbourbeau