Merged
Conversation
There already exist some Pytest markers, so there's no need to have a second function that checks the condition again and adds a manual skip, instead of decorating the functions with the marker.
These are already skipped by the `engine` fixture where necessary.
jsignell
approved these changes
Jun 14, 2021
Member
jsignell
left a comment
jsignell
left a comment
There was a problem hiding this comment.
This looks good to me. Thanks for the cleanup!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There already exist some Pytest markers, so there's no need to have a second function that checks the condition again and adds a manual skip, instead of decorating the functions with the marker.
black dask/flake8 dask/isort dask