Add support for histogram2d in dask.array#7827
Merged
Conversation
jrbourbeau
reviewed
Jun 23, 2021
douglasdavis
force-pushed
the
hist2d
branch
4 times, most recently
from
d6d70f2 to
d261fd2
Compare
jrbourbeau
reviewed
Jul 6, 2021
Member
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks for the updates @douglasdavis! I'm almost positive the failing CI build is totally unrelated to the changes here (confirming over in #7878)
jrbourbeau
reviewed
Jul 7, 2021
Member
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
Just merged main into this branch to resolve the unrelated macOS Python 3.7 CI failure
douglasdavis
force-pushed
the
hist2d
branch
2 times, most recently
from
146a019 to
db5a42b
Compare
Member
|
@douglasdavis this is ready to be merged right? |
Member
Author
|
Yep :) just been rebasing it every now and then to watch out for conflicts |
Member
|
Ok cool cool. I am going to merge today if it passes CI. |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #xxxxblack dask/flake8 dask/isort daskThis PR completes support of the NumPy histogramming API in dask.array. This is the final chapter of the story told by #7307, #7387, #7634. Conveniently, histogramdd is 99% of what we need for histogram2d. Tests for histogram2d uncovered the need for a small bugfix in histogramdd (this PR includes that fix, the change on line 1326).