Use separate files for each DataFrame function and method#7890
Use separate files for each DataFrame function and method#7890
Conversation
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @jsignell, this looks great! A couple of questions that come to mind:
- Should we also update the
cleancommand indocs/Makefileto also thegenerateddirectory? I'm not sure what sort of caching sphinx does here - Does this change impact other projects which are using
intersphinxto link to Dask API docs? I'm wondering if we need to add redirects for this, or if things will continue to work as is
Yes!
I'm not sure about that one, but I am tempted to take a merge and see approach. |
|
I'll look into make.bat tomorrow :( |
|
I tried to copy from xarray or numpy and neither of them have a make.bat. Now I'm wondering if we need it |
|
This is great. Two comments, neither of which are likely relevant:
|
+1
Hmm, I'm not able to reproduce locally. You might try |
I'm wondering if you have an old sphinx version. According to the docs, this setting changed to true by default in 4.0 https://www.sphinx-doc.org/en/master/usage/extensions/autosummary.html#confval-autosummary_generate
Yep that's the plan! |
|
Merged |
|
Merging! |
|
This is amazing - thank you very much! |
|
nvmd Ben, I see that it's hardcoded over there. I'll open a PR. |
ref: dask/dask#7890 Authors: - Julia Signell (https://github.com/jsignell) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) URL: #8772
|
This is great, thanks @jsignell!
Looking at pandas' docs, it seems they were able to handle API redirect in a somewhat straightforward way using sphinx |
|
Yeah our case is slightly different because in our case we would want to redirect a link where all the information is stored in the anchor. So it'd be going from https://docs.dask.org/en/latest/array-api.html#dask.array.add to https://docs.dask.org/en/latest/generated/dask.array.add.html for instance. I am leaning towards not worrying too much about this. |
black dask/flake8 dask/isort daskThis copies the pattern that numpy and xarray use. You should be able to see the difference in load time https://dask--7890.org.readthedocs.build/en/7890/dataframe-api.html