Change graphviz font family to sans#7931
Merged
martindurant merged 5 commits intodask:mainfrom Jul 28, 2021
Merged
Conversation
Contributor
|
My personal opinion here is the same as described in #7869 (comment)
|
Member
|
I am also +1 here, so lets merge in a day if there is no dissent. |
Contributor
Author
|
This is ready to merge, if no one has any issues. |
Contributor
Author
|
💛 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
black dask/flake8 dask/isort daskI was working on #7869 and realized that the Graphviz output would look even cleaner if we use a sans-serif font instead of the current serif font.
In this PR, I have changed the font of the Graphviz from Times-Roman to
RobotoHelvetica. I have also cleaned the code in the methodto_graphviz()to be more consistent indot.py(LOW LEVEL) andhighlevelgraph.py(HIGH LEVEL). Now, they look similar and it might be easier to work with this code in the future.It follows the https://marketing.dask.org/en/latest/colors.html

(Font mentioned in image: Roboto)
Even the HTML Representation uses a Sans font, so it makes sense to have the Graph representations also follow suit.
Demo
Before
After
Before
After
/cc @GenevieveBuckley @martindurant