Add axes property to DataFrame and Series#8069
Merged
jrbourbeau merged 4 commits intodask:mainfrom Aug 27, 2021
Merged
Conversation
Collaborator
|
Can one of the admins verify this patch? |
jsignell
reviewed
Aug 19, 2021
Member
|
@dask/gpu can someone trigger CI? |
Member
|
ok to test |
jrbourbeau
reviewed
Aug 19, 2021
| def test_series_axes(): | ||
| ps = pd.Series(["abcde"]) | ||
| ds = dd.from_pandas(ps, npartitions=2) | ||
| assert len(ds.axes) == 1 |
Member
There was a problem hiding this comment.
Let's compare to the expected len from pandas instead. What you already have seems right, but comparing to pandas directly will be more clear to readers and robust to potential future changes
Suggested change
| assert len(ds.axes) == 1 | |
| assert len(ds.axes) == len(ps.axes) |
| def test_axes(): | ||
| pdf = pd.DataFrame({"col1": [1, 2], "col2": [3, 4]}) | ||
| df = dd.from_pandas(pdf, npartitions=2) | ||
| assert len(df) == 2 |
Member
There was a problem hiding this comment.
Similar comment here
Suggested change
| assert len(df) == 2 | |
| assert len(df.axes) == len(pdf.axes) |
jrbourbeau
approved these changes
Aug 27, 2021
Member
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @dotNomad! This is in
Also, I noticed this is your first code contribution to this repository. Welcome!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Issue #1259
black dask/flake8 dask/isort dask