Merged
Conversation
github-actions
bot
added
dataframe
dispatch
Member
Author
|
I based this off of the int64index branch just to see if tests could pass. You can see the relevant changes at: https://github.com/dask/dask/pull/8151/files/57aabfe7081e16bfe647e58a26ba16332d734f33..03cc7f0a144aa0fb0473b47b7fbc99aa31181717 EDIT: I just rebased since #8144 merged |
Member
Author
|
rerun tests |
jsignell
commented
Sep 16, 2021
| def _drop_duplicates_rename(df): | ||
| # Avoid duplicate index labels in a groupby().apply() context | ||
| # https://github.com/dask/dask/issues/3039 | ||
| # https://github.com/pandas-dev/pandas/pull/18882 |
Member
Author
There was a problem hiding this comment.
This refers to a version of pandas that is no longer supported.
Member
Author
|
@jrbourbeau this both removes the skip for the failing groupby test that was introduced in #8142 and fixes all the upstream test failures except for one last pesky little test. I think we should merge it before the release. |
jrbourbeau
reviewed
Sep 21, 2021
Member
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
Just checking in here, @jsignell is this good to go?
Member
Author
|
Yes this is done :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
black dask/flake8 dask/isort daskImplementing @TomAugspurger's workaround from #8137 (comment)