Remove warning filters in tests that are no longer needed#8155
Merged
Remove warning filters in tests that are no longer needed#8155
Conversation
jsignell
changed the title
jrbourbeau
reviewed
Sep 16, 2021
Comment on lines
-169
to
-170
| if ufunc == "fix" and np.__version__ >= "1.13.0": | ||
| pytest.skip("fix calls floor in a way that we do not yet support") |
Member
There was a problem hiding this comment.
Hmm this seems to be causing errors still. Maybe we should just drop the and np.__version__ >= "1.13.0" part for now?
Member
Author
There was a problem hiding this comment.
Oh I didn't mean include that change 🤦
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of these changes is to get rid of warning filters in tests wherever possible.