Add pre-commit to test requirements for pip installation#8257
Merged
Add pre-commit to test requirements for pip installation#8257
Conversation
Member
|
Thanks @GenevieveBuckley!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds pre-commit to the test requirements for people installing Dask with pip.
If users follow the development guidelines for Dask installation, they should not need to install new packages to make a pull request. The pull request template asks whether your branch passes
pre-commit run --all-files, so this is an important test requirement.Also, if you follow the development installation guide but use conda instead of pip, then we do already include pre-commit. This PR makes the development experience more consistent for pip users.
Closes #xxxxDoesn't close a specific issue, I found it after looking into this comment: [DOCS] Development guide for pip-people incomplete? #7358 (comment)pre-commit run --all-files