Make scheduler kwarg pass though to sub functions in da.assert_eq#8755
Merged
Make scheduler kwarg pass though to sub functions in da.assert_eq#8755
da.assert_eq#8755Conversation
jcrist
approved these changes
Feb 25, 2022
| await c.compute(z, optimize_graph=False) | ||
| da.assert_eq(z, x) | ||
| c.compute(z, optimize_graph=False) | ||
| da.assert_eq(z, x, scheduler=c) |
phobson
pushed a commit
to phobson/dask
that referenced
this pull request
Feb 28, 2022
…ask#8755) * Make `da.assert_eq` scheduler kwarg affect nested funtions * Update tests to use scheduler kwarg * Fix `assert_eq` test
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow on to #8700
I noticed while running these tests that when the distributed tests are run in parallel they often
xfail. I'm wondering if it would be worth adding a separate job that just runs the distributed test withoutnautoEDIT - I'm not seeing the xfail behavior on CI. It's possible that I was doing something weird locally.