Merged
Conversation
jsignell
reviewed
Mar 15, 2022
Member
jsignell
left a comment
jsignell
left a comment
There was a problem hiding this comment.
This looks like a very reasonable and isolated change. I just have one question about how the new kwarg will fit in with existing args. Maybe the solution is just, it should go at the end.
Contributor
Author
|
Given the positive feedback so far (thank you!), I've taken the time to write a test ... |
Member
|
Thanks @davidhassell! This is in :) |
Contributor
Author
|
Wow - that was quick! Thank you for sorting it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reduction#8804pre-commit run --all-filesExisting tests pass. Waiting for approval before writing tests for the new functionality. Thanks.Edit: new test now added