Custom collection example docs fix (remove comment about automatic optimizations)#8807
Merged
Custom collection example docs fix (remove comment about automatic optimizations)#8807
Conversation
jcrist
approved these changes
Mar 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like a note about automatic optimizations performed by the scheduler was removed in #4752 (this was specific to the optimization docs). There is an inline code comment note in the custom collections docs that mentions automatic optimizations happen. This PR fixes that. The discussion in the issue (from 2019, #4585) mentions that now the recommendation is to cull on your own.