Skip to content

Better error for failed wildcard path in dd.read_csv() (fixes #8878)#8908

Merged
jcrist merged 3 commits intodask:mainfrom
rfilmyer:main
Apr 13, 2022
Merged

Better error for failed wildcard path in dd.read_csv() (fixes #8878)#8908
jcrist merged 3 commits intodask:mainfrom
rfilmyer:main

Conversation

@rfilmyer
Copy link
Copy Markdown
Contributor

Makes an empty wildcard path URL specification in dd.read_csv(compression='infer') fail with OSError: [urlpath] resolved to no files instead of IndexError: list index out of range

@GPUtester
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@pavithraes
Copy link
Copy Markdown
Member

@rfilmyer Thanks for opening this PR, it looks good to me!

@pavithraes
Copy link
Copy Markdown
Member

Thanks for the updates, @rfilmyer! The failing windows test seems unrelated. :)

@jsignell I think we're good to go! Could you please take a quick look and help merge?

Copy link
Copy Markdown
Member

@jcrist jcrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jcrist jcrist merged commit 783b15b into dask:main Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed wildcard matching with dd.read_csv("s3://[...]/*.csv", compression='infer') raises unintuitive error message

5 participants