Call fs.invalidate_cache in to_parquet#8994
Merged
Conversation
Invalidate the client-side filesystem listings cache before returning from `to_parquet`. This helps ensure that doing a write followed by an immediate read works - without it the filesystem might use outdated cache information when reading recently written files resulting in `FileNotFound` errors. There's not really a good way to test this, so using a mock for now.
bryanwweber
approved these changes
Apr 28, 2022
Contributor
bryanwweber
left a comment
bryanwweber
left a comment
There was a problem hiding this comment.
Thanks @jcrist, this looks like it will fix the issue. I agree about the test, hard to check otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invalidate the client-side filesystem listings cache before returning
from
to_parquet. This helps ensure that doing a write followed by animmediate read works - without it the filesystem might use outdated
cache information when reading recently written files resulting in
FileNotFounderrors.There's not really a good way to test this, so using a mock for now.
Fixes #8028
Fixes #7965
pre-commit run --all-files