Handle enumerate and generator inputs to from_map#9066
Merged
Conversation
charlesbluca
approved these changes
May 11, 2022
Member
|
Thank you both! |
jrbourbeau
reviewed
May 11, 2022
| ["A", "B", "B", "C", "C", "C"], | ||
| index=[0, 0, 1, 0, 1, 2], | ||
| ) | ||
| assert_eq(ddf.compute(), expect) |
Member
Author
There was a problem hiding this comment.
Oh no, I missed that. No - the compute() is not necessary.
erayaslan
pushed a commit
to erayaslan/dask
that referenced
this pull request
May 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new
from_mapAPI does not correclty handle when elements ofiterablesare not of typelist. This PR should allow us to handleenumerateand generator objects correctly.TypeErrorwhen usingfrom_maponenumerateobject #9064pre-commit run --all-files