Add type annotations to dd.from_pandas and dd.from_delayed#9237
Merged
ian-r-rose merged 16 commits intodask:mainfrom Jul 21, 2022
Merged
Add type annotations to dd.from_pandas and dd.from_delayed#9237ian-r-rose merged 16 commits intodask:mainfrom
dd.from_pandas and dd.from_delayed#9237ian-r-rose merged 16 commits intodask:mainfrom
Conversation
Collaborator
|
Can one of the admins verify this patch? |
douglasdavis
reviewed
Jul 5, 2022
douglasdavis
reviewed
Jul 5, 2022
pavithraes
reviewed
Jul 5, 2022
pavithraes
reviewed
Jul 5, 2022
pavithraes
reviewed
Jul 5, 2022
pavithraes
reviewed
Jul 5, 2022
Member
|
We'll also need to include |
Member
|
@multimeric Thank you for opening this PR! |
Co-authored-by: Doug Davis <ddavis@ddavis.io>
Co-authored-by: Doug Davis <ddavis@ddavis.io>
Contributor
Author
|
I wonder if there are any suggestions about how I can type check a |
pavithraes
reviewed
Jul 14, 2022
ian-r-rose
reviewed
Jul 14, 2022
ian-r-rose
reviewed
Jul 14, 2022
pavithraes
reviewed
Jul 14, 2022
Co-authored-by: Ian Rose <ian.r.rose@gmail.com>
Co-authored-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
Contributor
Author
|
I've also removed the redundant type annotations as per this discussion. |
Contributor
Author
|
All good to merge? |
Member
|
@multimeric This looks great, thank you! |
pavithraes
approved these changes
Jul 18, 2022
Member
|
@multimeric Thank you for working on this! |
pavithraes
changed the title
dd.from_pandas and dd.from_delayed
3 tasks
jyap-abc
pushed a commit
to jjyap/dask
that referenced
this pull request
Aug 8, 2022
…dask#9237" This reverts commit 84533ea.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that this method actually accepts a single
Delayedso I've tried to codify that in the docstring + type signature. And I improved the type signatures a little while I was there. I couldn't fix themetatype annotation because of reasons discussed in #9233.pre-commit run --all-files