Skip to content

Fixing enforce_metadata doc, not checking for dtypes#9474

Merged
ncclementi merged 1 commit intodask:mainfrom
epizut:main
Sep 13, 2022
Merged

Fixing enforce_metadata doc, not checking for dtypes#9474
ncclementi merged 1 commit intodask:mainfrom
epizut:main

Conversation

@epizut
Copy link
Copy Markdown
Contributor

@epizut epizut commented Sep 8, 2022

The current apply_and_enforce() implementation does not raise on mismatching dtypes so we need to update the doc accordingly

The current apply_and_enforce() implementation does not raise on mismatching dtypes
@GPUtester
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

Copy link
Copy Markdown
Contributor

@phobson phobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @epizut. This looks good to me.

Copy link
Copy Markdown
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the original intent of the docstrings was types (like DataFrame vs Series), not dtype but I'm fine with the change.

@epizut
Copy link
Copy Markdown
Contributor Author

epizut commented Sep 12, 2022

Makes sense,
Now, the docstring specifically says 'dtypes' so there is no ambiguity.

@ncclementi
Copy link
Copy Markdown
Member

@epizut Thank you for this contribution, this goes in! Congrats on your first PR to dask 🎉

@ncclementi ncclementi merged commit d20c729 into dask:main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dask.dataframe.map_partitions enforce_metadata not checking for dtypes

5 participants