Fixing enforce_metadata doc, not checking for dtypes#9474
Merged
ncclementi merged 1 commit intodask:mainfrom Sep 13, 2022
Merged
Fixing enforce_metadata doc, not checking for dtypes#9474ncclementi merged 1 commit intodask:mainfrom
ncclementi merged 1 commit intodask:mainfrom
Conversation
The current apply_and_enforce() implementation does not raise on mismatching dtypes
Collaborator
|
Can one of the admins verify this patch? Admins can comment |
jsignell
reviewed
Sep 12, 2022
Member
jsignell
left a comment
There was a problem hiding this comment.
I think the original intent of the docstrings was types (like DataFrame vs Series), not dtype but I'm fine with the change.
Contributor
Author
|
Makes sense, |
Member
|
@epizut Thank you for this contribution, this goes in! Congrats on your first PR to dask 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current apply_and_enforce() implementation does not raise on mismatching dtypes so we need to update the doc accordingly
pre-commit run --all-files