Conversation
added 2 commits
October 10, 2022 13:09
Collaborator
|
Can one of the admins verify this patch? Admins can comment |
Member
|
add to allowlist |
Member
|
@ChrisJar Thank you for the contribution. Would you mind fixing the conflicts so we can get a review in progress? |
rjzamora
reviewed
Oct 18, 2022
rjzamora
approved these changes
Oct 21, 2022
Member
rjzamora
left a comment
rjzamora
left a comment
There was a problem hiding this comment.
This looks good @ChrisJar - Thanks!
Would you be able to run dask_cudf tests locally to confirm that this doesn't cause any unexpected breakages?
Contributor
Author
|
@rjzamora Thanks for the reviews! I can confirm all dask_cudf tests pass locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5294