Skip to content

Revert importlib.metadata workaround#9658

Merged
jrbourbeau merged 5 commits intodask:mainfrom
jrbourbeau:revert-importlib-workaround
Nov 16, 2022
Merged

Revert importlib.metadata workaround#9658
jrbourbeau merged 5 commits intodask:mainfrom
jrbourbeau:revert-importlib-workaround

Conversation

@jrbourbeau
Copy link
Copy Markdown
Member

Following up on #9604, I believe this was an issue in bokeh that has been fixed with the latest bokeh=3.0.2 release (xref bokeh/bokeh#12588)

cc @charlesbluca

@jrbourbeau jrbourbeau changed the title Revert importlib.metadata workaround [DNM] Revert importlib.metadata workaround Nov 14, 2022
Copy link
Copy Markdown
Member

@charlesbluca charlesbluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jrbourbeau! Looks like the affected tests are passing now so this LGTM

@jrbourbeau jrbourbeau changed the title [DNM] Revert importlib.metadata workaround Revert importlib.metadata workaround Nov 15, 2022
@jrbourbeau
Copy link
Copy Markdown
Member Author

mindeps failures are unrelated and being handled in #9668

@jrbourbeau jrbourbeau merged commit 2297590 into dask:main Nov 16, 2022
@jrbourbeau jrbourbeau deleted the revert-importlib-workaround branch November 16, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants