Fix some outdated information/typos in development guide#9893
Merged
jrbourbeau merged 4 commits intodask:mainfrom Feb 3, 2023
Merged
Fix some outdated information/typos in development guide#9893jrbourbeau merged 4 commits intodask:mainfrom
jrbourbeau merged 4 commits intodask:mainfrom
Conversation
phofl
commented
Jan 29, 2023
docs/source/develop.rst
Outdated
| Pandas' documentation and links on this subject at | ||
| https://pandas.pydata.org/pandas-docs/stable/contributing.html | ||
| pandas' documentation and links on this subject at | ||
| https://pandas.pydata.org/pandas-docs/stable/development/contributing.html |
Collaborator
Author
There was a problem hiding this comment.
We could also point to the dev-docs. We adjusted things quite regularly recently.
Member
There was a problem hiding this comment.
I'll defer to you as to which link would be a better source for contributors
Collaborator
Author
There was a problem hiding this comment.
Then lets point to the dev version, bugs are fixed sooner there
jrbourbeau
reviewed
Feb 3, 2023
Member
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @phofl! Happy to merge this as is or we can update the pandas contributing list as you mentioned
docs/source/develop.rst
Outdated
| Pandas' documentation and links on this subject at | ||
| https://pandas.pydata.org/pandas-docs/stable/contributing.html | ||
| pandas' documentation and links on this subject at | ||
| https://pandas.pydata.org/pandas-docs/stable/development/contributing.html |
Member
There was a problem hiding this comment.
I'll defer to you as to which link would be a better source for contributors
jrbourbeau
approved these changes
Feb 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-filesSaw these when going over the development guide