Skip to content

Fix DataFrame.info() tests for pandas 2.0#9909

Merged
jrbourbeau merged 1 commit intodask:mainfrom
jrbourbeau:pandas-2.0-info-fixup
Feb 2, 2023
Merged

Fix DataFrame.info() tests for pandas 2.0#9909
jrbourbeau merged 1 commit intodask:mainfrom
jrbourbeau:pandas-2.0-info-fixup

Conversation

@jrbourbeau
Copy link
Copy Markdown
Member

dask/dataframe/tests/test_dataframe.py::test_info and dask/dataframe/tests/test_dataframe.py::test_categorize_info are failing in our upstream build due to the use of hard-coded expected output that is slightly different when using pandas 2.0. This PR generalizes the hard-coded value a bit to make things work.

Note that I think we could probably re-work our info-related tests to not use hard-coded values at all, but that will take more time, so I'm going with the simple fix here.

cc @j-bennet

Copy link
Copy Markdown
Contributor

@j-bennet j-bennet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jrbourbeau jrbourbeau merged commit a952a77 into dask:main Feb 2, 2023
@jrbourbeau jrbourbeau deleted the pandas-2.0-info-fixup branch February 2, 2023 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants