Fix test_numeric_column_names for pandas 2.0#9937
Merged
jrbourbeau merged 1 commit intodask:mainfrom Feb 10, 2023
Merged
Conversation
j-bennet
changed the title
test_numeric_column_names for pandas 2.0 compatibility
jrbourbeau
approved these changes
Feb 10, 2023
Member
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @j-bennet! This looks good to me. For reference, I confirmed the changes here fix dask/dataframe/tests/test_groupby.py::test_numeric_column_names when running with the nightly version of pandas
jrbourbeau
changed the title
test_numeric_column_names for pandas 2.0 compatibilitytest_numeric_column_names for pandas 2.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following upstream failure with pandas 2.0:
It appears that
applyongroupbywould losedtypeofcolumns. Oddly, this didn't happen with 1.5, might be because default indexdtypehas changed.Xref #9736.
pre-commit run --all-files