Skip to content

Fix copy on write failure in test_idxmaxmin#9944

Merged
jrbourbeau merged 1 commit intodask:mainfrom
phofl:cow
Feb 16, 2023
Merged

Fix copy on write failure in test_idxmaxmin#9944
jrbourbeau merged 1 commit intodask:mainfrom
phofl:cow

Conversation

@phofl
Copy link
Copy Markdown
Collaborator

@phofl phofl commented Feb 10, 2023

  • Closes #xxxx
  • Tests added / passed
  • Passes pre-commit run --all-files

Chained indexing will never work under CoW. Rewrote to use equivalent iloc.

Copy link
Copy Markdown
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phofl!

@jrbourbeau jrbourbeau changed the title Fix some copy on write failures Fix copy on write failure in test_idxmaxmin Feb 16, 2023
@jrbourbeau jrbourbeau merged commit adebc8e into dask:main Feb 16, 2023
@phofl phofl deleted the cow branch February 16, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants