Relax dask.dataframe assert_eq type checks#9989
Merged
Conversation
This allows other dask.dataframe-like projects to leverage assert_eq and shouldn't negatitvely affect the power of current tests within dask.dataframe.
Member
Author
|
cc @rjzamora |
rjzamora
previously approved these changes
Feb 22, 2023
Member
There was a problem hiding this comment.
This make sense to me. I was initially a bit uncomfortable until I realized that the modified lines are within an if hasattr(dsk, "__dask_graph__") block, which is equivalent to asserting that is_dask_collection(dsk) is True. Therefore, I agree that we shouldn't be hindering existing test coverage.
rjzamora
reviewed
Feb 22, 2023
rjzamora
reviewed
Feb 22, 2023
dask/dataframe/utils.py
Outdated
| if result is None: | ||
| result = dsk.compute(scheduler=scheduler) | ||
| if isinstance(dsk, dd.Index): | ||
| if is_index_like(dsk._meta): |
Member
There was a problem hiding this comment.
Looks like dask_cudf.Index does not satisfy is_index_like when the underlying meta is a MultiIndex, because a cudf.MultiIndex does not have a dtype attribute (while pd.MultiIndex does) :/
I'm sure this can changed in cudf, but we could also do something like if isinstance(dsk, dd.Index) or is_index_like(dsk._meta).
rjzamora
approved these changes
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows other dask.dataframe-like projects to leverage assert_eq and shouldn't negatitvely affect the power of current tests within dask.dataframe.