Avoid windows NotaDirectoryErrors in tests

[mrocklin]

We have many tests that fail with NotADiirectoryErrors in windows. (see #6455 for an eample). It looks like we've tried to address this with the utils_test.py::_SafeTemporaryDirectory class. However it's only used in one of a few places in that module. Should we use it more widely? Alternatively, should we care about the windows error here?

cc @graingert if you have thoughts

[graingert]

_SafeTemporaryDirectory is just ignoring an intermittent error that we should care about but we didn't have time to fix. We should avoid using it more widely if possible.

I suspect the NotADirectoryError in #6455 is a side effect of a task being cancelled which is allowing a process to avoid being terminated

[mrocklin]

OK, thanks for the note

…

On Fri, May 27, 2022 at 9:26 AM Thomas Grainger ***@***.***> wrote: _SafeTemporaryDirectory is just ignoring an intermittent error that we should care about but we didn't have time to fix. We should avoid using it more widely if possible. I suspect the NotADirectoryError in #6455 <#6455> is a side effect of a task being cancelled which is allowing a process to avoid being terminated — Reply to this email directly, view it on GitHub <#6457 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACKZTAHOMIAQWUWOEMZ4LDVMDLSFANCNFSM5XBAYLMQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>