should pubsub-remove-subscribers actually be pubsub-remove-subscriber ?

[ksk438]

distributed/distributed/pubsub.py

Line 188 in 0dc9e88

{"op": "pubsub-remove-subscribers", "name": name}

I don't see an operation called "pubsub-remove-subscribers" .... only "pubsub-remove-subscriber". I have seen a related error in the past but don't have it on hand. Can anyone comment?

I have patched it in my local copy to be the latter and it has been working well.

[fjetter]

Yes, this appears to be a typo. Looks like this is untested. Are you interested in contributing a patch (with a test)?

[ksk438]

I don't have the capacity at the moment. If nobody picks it up I could give it a shot in a couple months I believe.

[killcoder]

Still not patched

dask 2024.11.2
distributed 2024.11.2

distributed\core.py", line 913, in handle_stream
    handler = self.stream_handlers[op]
              ~~~~~~~~~~~~~~~~~~~~^^^^
KeyError: 'pubsub-remove-subscribers'

[hendrikmakait]

@killcoder: A fix is welcome. As a heads-up: The pub-sub functionality has already been deprecated.

[killcoder]

@hendrikmakait thanks for the response, I managed to figure out the replacement subscriber_topic / log_event