bump version to 1.21.2#1809
Closed
mrocklin wants to merge 1 commit intodask:masterfrom
Closed
Conversation
jakirkham
reviewed
Mar 5, 2018
| - Support minimum, maximum, wait_count keywords in Adaptive (:pr:`1797`) `Jacob Tomlinson`_ and `Matthew Rocklin`_ | ||
| - Support async protocols for LocalCluster, replace start= with asynchronous= (:pr:`1798`) `Matthew Rocklin`_ | ||
| - Avoid restarting workers when nanny waits on scheduler (:pr:`1793`) `Matthew Rocklin`_ | ||
| - Use ``IOStream.read_into()`` when available `Antoine Pitrou`_ |
jakirkham
reviewed
Mar 5, 2018
| - Fix bug where client was noisy when scheduler closed unexpectedly (:pr:`1806`) `Matthew Rocklin`_ | ||
| - Use string-based timedeltas (like ``'500 ms'``) everywhere `Matthew Rocklin`_ | ||
| - Keep logs in scheduler and worker even if silenced (:pr:`1803`) `Matthew Rocklin`_ | ||
| - Support minimum, maximum, wait_count keywords in Adaptive (:pr:`1797`) `Jacob Tomlinson`_ and `Matthew Rocklin`_ |
jakirkham
reviewed
Mar 5, 2018
|
|
||
| - Fix bug where we didn't check idle/saturated when stealing (:pr:`1801`) `Matthew Rocklin`_ | ||
| - Fix bug where client was noisy when scheduler closed unexpectedly (:pr:`1806`) `Matthew Rocklin`_ | ||
| - Use string-based timedeltas (like ``'500 ms'``) everywhere `Matthew Rocklin`_ |
Member
|
Looks pretty good. Had a couple questions about changes without a PR ref and one suggestion about a change worth adding. |
Member
Author
|
Added the other PRs (they were cases where I decided to rebase rather than
squash). I'm going to opt to avoid 1800 for now. It's not yet relevant
without future work.
…On Mon, Mar 5, 2018 at 5:04 PM, jakirkham ***@***.***> wrote:
Looks pretty good. Had a couple questions about changes without a PR ref
and one suggestion about a change worth adding.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1809 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AASszKfg6OGzNItwZYiKlMu4poLvydkAks5tbbZYgaJpZM4Sdt2x>
.
|
jakirkham
approved these changes
Mar 5, 2018
Member
|
LGTM. Thanks. Only mentioned 1800 as it looked interesting. If you would rather not include it, that's ok. :) |
Member
Author
|
Done manually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also #1808