Skip to content

Fix uri_from_host_port import in dask-mpi#2683

Merged
mrocklin merged 1 commit intodask:masterfrom
jrbourbeau:fix-mpi-cli
May 10, 2019
Merged

Fix uri_from_host_port import in dask-mpi#2683
mrocklin merged 1 commit intodask:masterfrom
jrbourbeau:fix-mpi-cli

Conversation

@jrbourbeau
Copy link
Copy Markdown
Member

@jrbourbeau jrbourbeau commented May 10, 2019 •
edited
Loading

There is an ImportError for uri_from_host_port in the dask-mpi cli command:

$ dask-mpi --help
Traceback (most recent call last):
  File "/Users/jbourbeau/miniconda/envs/dask-dev/bin/dask-mpi", line 6, in <module>
    from distributed.cli.dask_mpi import go
  File "/Users/jbourbeau/miniconda/envs/dask-dev/lib/python3.6/site-packages/distributed/cli/dask_mpi.py", line 11, in <module>
    from distributed.cli.utils import check_python_3, uri_from_host_port
ImportError: cannot import name 'uri_from_host_port'

This PR fixes the import issue (uri_from_host_port lives in distributed.comm.addressing).

@mrocklin mrocklin merged commit 94dd92e into dask:master May 10, 2019
@mrocklin
Copy link
Copy Markdown
Member

mrocklin commented May 10, 2019

Thanks @jrbourbeau

muammar added a commit to muammar/distributed that referenced this pull request Jul 18, 2019
@muammar
Merge remote-tracking branch 'upstream/master'
c1a7dae 
* upstream/master:
  Add WeakSet _instances attributes to all classes (dask#2673)
  Cap worker's memory limit by the hard limit of the maximum resident memory (dask#2665)
  Switch from (ip, port) to address in tests (dask#2684)
  Catch RuntimeError to avoid serialization fail when using pytorch (dask#2619)
  Add CONTRIBUTING.md (dask#2680)
  Consolidate logic around services (dask#2679)
  Fix uri_from_host_port import in dask-mpi (dask#2683)
  Move dashboard_address logic into Scheduler/Worker (dask#2678)
  Fix pytest.config deprecation warning (dask#2677)
  Use config accessor method for "scheduler-address" (dask#2676)
  Add memory and disk aliases to Worker.data (dask#2670)
  Move interface/host/port handling from CLI to classes (dask#2667)
  Remove AioClient (dask#2668)
  Add release procedure doc (dask#2672)
  bump version to 1.28.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jrbourbeau @mrocklin