WIP: Add option to enable RMM logging#3924
Conversation
Co-authored-by: Benjamin Zaitlen <quasiben@users.noreply.github.com>
|
@jakirkham I pushed a commit which should fix the schema issue |
|
@jakirkham can you move this PR from Draft to Review ? |
jakirkham
left a comment
jakirkham
left a comment
There was a problem hiding this comment.
Draft seems like the correct status for this PR atm given the difficulty highlighted below. Thoughts on that would be welcome 🙂
| managed_memory=False, | ||
| initial_pool_size=pool_size, | ||
| logging=enable_logging, | ||
| log_file_name="", # Something more useful here ;) |
There was a problem hiding this comment.
We still need to fill this in with something. This is a bit tricky to get right as we would presumably want a different location depending on whether we are setting this on a worker, on the scheduler, or potentially on the client. However I'm not sure how we access that information from a context that is not inside one of those classes. Welcome thoughts on that though 🙂
There was a problem hiding this comment.
Maybe we should force the user to pass a path+filename prefix if logging is enabled and append the PID to it?
3 participants
Related to PR ( rapidsai/dask-cuda#322 )
Includes an option to enable RMM logging for Dask-CUDA workers.
cc @pentschev @quasiben