Protect profile against very large stacks#4082
Open
mrocklin wants to merge 2 commits into
Open
Conversation
This can come up in tracebacks when exporting profiles. This isn't quite right. We're chopping off the calling functions of the call stack rather than the called functions, but it's easiest to do it this way given how we've arranged our profile processing function. So the top of the call stack will appear somewhat disassociated, but will still be around. Mostly I don't care too much about pathological cases like these, as long as they don't ruin communication of the rest of the system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can come up in tracebacks when exporting profiles.
This isn't quite right. We're chopping off the calling functions of the
call stack rather than the called functions, but it's easiest to do it
this way given how we've arranged our profile processing function. So
the top of the call stack will appear somewhat disassociated, but will
still be around.
Mostly I don't care too much about pathological cases like these, as
long as they don't ruin communication of the rest of the system.