WIP: Add Semaphore.refresh_leases retries#4158
Draft
lr4d wants to merge 6 commits into
Draft
Conversation
This adds retries to the semaphore release method, which must be configured using "distributed.comm.retry.count". This may come to use when the scheduler is under high load and some release calls may fail. This PR also avoids raising an exception in case a release fails, instead a warning is logged at ERROR level, and the Semaphore.release method will return `False`. The lease will eventually be cleaned up during the semaphore lease validation check, which may be configured using "distributed.scheduler.locks.lease-validation-interval" and ""distributed.scheduler.locks.lease-timeout".
Contributor
Author
|
The rationale here is similar to the issue linked, to increase the robustness of the Semaphore during unstable periods. In case the refresh_leases method fails, we retry the operation. In case all retries fail, we generate an appropriate log message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #4151 , only the last commit is new.
The test added is still flaky.