Conversation
| click >= 6.7 | ||
| cloudpickle >= 1.5.0 | ||
| dask >= 2021.03.0 | ||
| dask >= 2021.04.1 | ||
| msgpack >= 0.6.0 | ||
| psutil >= 5.0 | ||
| sortedcontainers !=2.0.0, !=2.0.1 | ||
| psutil >= 5.4.7 | ||
| sortedcontainers >= 2.0.4 | ||
| tblib >= 1.6.0 | ||
| toolz >= 0.8.2 | ||
| toolz >= 0.10.0 |
There was a problem hiding this comment.
Note that:
-
The minimum versions for
click,psutil, andsortedcontainerswere bumped to fix conda solve errors -
daskwas bumped to avoid the issue reported here 2021.04.1 release community#150 (comment) -
toolzitself didn't need to be bumped, however there was a segmentation fault in CI due tocytoolz(which is pulled in from thedaskconda package). Bumping the minimumtoolzversion indirectly leads to a correspondingly newer version ofcytoolzbeing installed. Given that(cy)toolz=0.10.0is almost two years old, I think this is okay
|
@crusaderky would you mind taking a look at this PR when you get a chance? |
|
I think you should really have two separate tests:
ATM you're trying to do both in one test and as a result you're skipping a lot of tests - which significantly harms test coverage vs. minimum versions. |
|
Circling back here, it'd be good to get a minimum dependency CI build into |
|
Thanks for the ping @jrbourbeau! Yeah I can look into finishing this up |
This PR adds a new CI build which runs the test suite against the minimum version of
distributeds dependencies (similar to what we already do over indask/dask). This will allow us to test, to the best of our ability, that our specified minimum versions are valid.