Conversation
|
Can one of the admins verify this patch? |
Unit Test Results 12 files ± 0 12 suites ±0 7h 4m 34s ⏱️ + 4m 24s For more details on these failures, see this check. Results for commit b04d5c7. ± Comparison against base commit 6a17957. ♻️ This comment has been updated with latest results. |
|
|
||
| @pytest.fixture(scope="session") | ||
| @pytest.fixture(scope="session") # pragma: no cover | ||
| def valid_python_script(tmpdir_factory): | ||
| local_file = tmpdir_factory.mktemp("data").join("file.py") | ||
| local_file.write("print('hello world!')") | ||
| return local_file |
There was a problem hiding this comment.
This appears to be ancient and we should remove this function. Using the github search, this only pops up in distributed forks and was used in tests that have been removed two years ago in #3280
There was a problem hiding this comment.
FYI
The github search shows a test named test_dask_submit_cli_writes_result_to_stdout. Finding commits in the git history which touch this test is easy with git log, e.g.
git log -Stest_dask_submit_cli_writes_result_to_stdout shows all commits touching that test
There was a problem hiding this comment.
that is very helpful, thank you!
|
|
||
| @pytest.fixture(scope="session") | ||
| @pytest.fixture(scope="session") # pragma: no cover | ||
| def client_contract_script(tmpdir_factory): |
|
|
||
| @pytest.fixture(scope="session") | ||
| @pytest.fixture(scope="session") # pragma: no cover | ||
| def invalid_python_script(tmpdir_factory): |
…nto improve-coverage-utils_test
…ve-coverage-utils_test
3 participants
distributed/utils_test.py:Moved this into a separate PR from #5749. This one was a bit tricky, when unsure, I added
pragma no coverwhere the only reference was in a test that is already ignored in.coveragerc; if the function was called elsewhere inutils_test.py, I opted not to exclude. For some functions, I had trouble finding a reference (e.gdeep,slowdouble).