Open
Conversation
We test this functionality in test_nanny.py and test_worker.py. We also test the worker `--worker-port` keyword in the test just above. I don't know why this fails sometimes, I suspect due to some flakiness with the popen context manager. This is fringe enough and pops up often enough that I'm fine just skipping
Member
Author
|
Merging later tomorrow if there are no comments |
Contributor
Member
Author
|
I tried running the distributed/cli test suite in a loop 50 times locally and couldn't reproduce the original issue. I'd like to figure out what's actuallly going on here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We test this functionality in test_nanny.py and test_worker.py.
We also test the worker
--worker-portkeyword in the test just above.I don't know why this fails sometimes, I suspect due to some flakiness
with the popen context manager. This is fringe enough and pops up often
enough that I'm fine just skipping
pre-commit run --all-files