Skip to content

Try using 8786 throughout all of CLI tests#6053

Open
mrocklin wants to merge 1 commit intodask:mainfrom
mrocklin:cli-port
Open

Try using 8786 throughout all of CLI tests#6053
mrocklin wants to merge 1 commit intodask:mainfrom
mrocklin:cli-port

Conversation

@mrocklin
Copy link
Copy Markdown
Member

@mrocklin mrocklin commented Apr 1, 2022

If we fail, let's fail hard.

If we fail, let's fail hard.
@mrocklin mrocklin mentioned this pull request Apr 1, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2022

Unit Test Results

       18 files  +       6         18 suites  +6   9h 14m 18s ⏱️ + 3h 7m 19s
  2 697 tests +       3    2 612 ✔️ +     15       81 💤  -   11  4  - 1 
24 113 runs  +8 009  22 852 ✔️ +7 606  1 257 💤 +405  4  - 2 

For more details on these failures, see this check.

Results for commit a45169e. ± Comparison against base commit 073ccbd.

@fjetter
Copy link
Copy Markdown
Member

fjetter commented Apr 4, 2022

What's the benefit of doing this?

@mrocklin
Copy link
Copy Markdown
Member Author

mrocklin commented Apr 4, 2022

My sense is that we're not doing this so that we don't have tests conflicting with each other. But really, tests should be cleaning up anyway. Rather than try to avoid this problem, let's become even more sensitive to it so that we can identify what's wrong and fix it.

@fjetter
Copy link
Copy Markdown
Member

fjetter commented Apr 5, 2022

There is some value in using distinct ports as well, though. I like running my tests locally using pytest-xdist. If we fix all ports within this file, we can no longer run them in parallel.
We're not doing this in CI and I rarely run CLI tests locally so I'm OK with this

@mrocklin mrocklin requested a review from fjetter as a code owner January 23, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants