Try using 8786 throughout all of CLI tests#6053
Open
Conversation
If we fail, let's fail hard.
Contributor
Member
|
What's the benefit of doing this? |
Member
Author
|
My sense is that we're not doing this so that we don't have tests conflicting with each other. But really, tests should be cleaning up anyway. Rather than try to avoid this problem, let's become even more sensitive to it so that we can identify what's wrong and fix it. |
Member
|
There is some value in using distinct ports as well, though. I like running my tests locally using pytest-xdist. If we fix all ports within this file, we can no longer run them in parallel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we fail, let's fail hard.