Provide & use a few more host functions#6330
Draft
Conversation
jakirkham
force-pushed
the
add_host_concat
branch
16 times, most recently
from
aa0606a to
6ca4c82
Compare
Contributor
Unit Test Results 15 files ± 0 15 suites ±0 6h 15m 52s ⏱️ - 11m 1s For more details on these failures, see this check. Results for commit 292bbe3. ± Comparison against base commit c2b28cf. ♻️ This comment has been updated with latest results. |
jakirkham
force-pushed
the
add_host_concat
branch
8 times, most recently
from
da1fcf7 to
9259c13
Compare
Allows one to write `host_array()` instead of `host_array(0)` for simplicity.
Provide a way to copy an existing `memoryview` to a new one.
Provide a utility function that handles concatenating frames together using either NumPy backed memory or Python backed memory. Also performs flattening of the data.
Make sure if `ensure_memoryview` allocates memory that it use memory backed by the preferred host allocator. Which is either NumPy if available or `bytearray` if not.
jakirkham
force-pushed
the
add_host_concat
branch
from
9259c13 to
292bbe3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
host_arraytodistributed.utilsto make it easier to use in other places outside ofcomms. Also include a couple other utility functions in the same vein to allow copy and concatenating frames. Updateensure_memoryviewto use these. Also make use of them incomms and `protocols.pre-commit run --all-files